Skip to content

test: cover Claude ultra no-op, Codex excludeUltra, mobile Priority - #150

Draft
cursor[bot] wants to merge 1 commit into
devfrom
cursor/missing-test-coverage-f0f5
Draft

test: cover Claude ultra no-op, Codex excludeUltra, mobile Priority#150
cursor[bot] wants to merge 1 commit into
devfrom
cursor/missing-test-coverage-f0f5

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Summary

Daily coverage pass for recently merged risky paths that lacked direct regression tests: Claude mid-session Codex ultra handling, Claude Codex-sub catalog excludeUltra, and the mobile home-composer Priority toggle synthesized from fast-only variants (#146).

Tiny testability extract only — mobile option synthesis moved into a pure helper; no user-facing behavior change.

Risky behavior now covered

Test files added/updated

  • apps/server/test/unit/agents/claude-agent.provider.spec.ts — ultra skip cases
  • apps/server/test/unit/agents/codex-model-options.spec.tsexcludeUltra unit case
  • apps/mobile/src/lib/model-option-descriptors.ts + .spec.ts — extracted helper + 5 specs
  • apps/mobile/src/components/home-composer.tsx — uses the helper (behavior-preserving)

Why these tests materially reduce regression risk

  • Sending invalid Claude effortLevel: 'ultra' mid-session can break live query flag updates for Codex-sub sessions.
  • Re-adding ultra to Claude picker rows would offer a tier the Claude runtime cannot honor.
  • Losing the Priority synthesis would hide a control users rely on for Codex/Cursor fast models on phone.

Changes

Type

  • test — test-only

Checklist

  • TDD-first — wrote specs for the missing behaviors; mobile helper extracted to make them pass
  • Suite is green — targeted: server Claude + Codex option specs (66 pass); mobile model-option-descriptors.spec.ts (5 pass)
  • Changeset — skipped (<!-- no-changeset -->; test + behavior-preserving extract)
  • Docs synced — N/A (no API/docs change)
  • No secrets committed
  • No new vulnerabilities introduced

Test plan

cd apps/server && bun test test/unit/agents/claude-agent.provider.spec.ts test/unit/agents/codex-model-options.spec.ts
cd apps/mobile && bun run test src/lib/model-option-descriptors.spec.ts

Related issues / PRs

Refs #143, #146. Follow-up to coverage automation #142.

Screenshots / recordings

N/A

Open in Web View Automation 

Lock regressions for mid-session Codex ultra on Claude, Claude Codex-sub
catalog rows that must drop ultra, and the mobile home-composer Priority
toggle synthesized from fast-only variants (#146).

Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant